Repository navigation
review-agents.md: trusting the work directory is a change here - #4
Merged
bbondy merged 1 commit intoNov 13, 2026
Merged
Conversation
Item 2 of "What would close the gap" asked bravebot for a way to read a named directory as trusted. --trust-workspace already does that for the working directory, and each PR's worktree is inside the work directory. So the fix is on this side: start the session in the work directory and reach the bot directory through --add-dir. That only matters once bypass is gone, since bypass trusts the workspace and vouches for every read (MODE-4). For the same reason, weakness 4 no longer calls --trust-workspace a condition of the widened writes. Bypass trusts the working directory with or without the flag.
bbondy
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only. This follows up #3.
Item 2 of "What would close the gap" was wrong. It asked bravebot for a way to read a named directory as trusted.
--trust-workspacealready does that for the working directory. The reviewer just points it at the bot directory, and reaches the work directory through--add-dir, which vouches for nothing (CLI-11, TRUST-26). Each PR's worktree sits at<work>/<pr>/source, so starting the session in the work directory with--trust-workspacewould trust everything the review reads. That's a change in this repo, not in bravebot.It only matters once bypass is gone. Bypass trusts the workspace and vouches for every read anyway (MODE-4). Moving the trust today would change nothing, so this PR has no code change.
Weakness 4 corrected. For the same reason, it no longer calls
--trust-workspacea condition of the widened writes. Bypass trusts the working directory with or without the flag.What's left on bravebot's side:
--run-network closedthat can still startpython3on Linux.Testing: not run, since only
docs/review-agents.mdchanged and no test reads it.